Add plugins #30
Open
Add plugins #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@leebyron Lee, would you care to review this and provide feedback? Thanks. |
leebyron
requested changes
Jan 8, 2021
Owner
leebyron
left a comment
leebyron
left a comment
There was a problem hiding this comment.
Sorry for not seeing this change before and thank you for this contribution! This project has been a bit sleepy over the last year or so.
If you're still interested in pursuing it, I've left some comments
Comment on lines
+33
to
+39
| formatText, | ||
| escape, | ||
| escapeCode, | ||
| updateBiblio, | ||
| getTerms, | ||
| anchorize, | ||
| join |
Owner
There was a problem hiding this comment.
These are implementation details that might change in the future - I'd suggest avoiding exporting them and directly relying on them
| var fs = require('fs'); | ||
| var path = require('path'); | ||
| var specmd = require('../'); | ||
| var yargs = require('yargs'); |
Owner
There was a problem hiding this comment.
Could you please remove yargs and use the existing simplified argument parsing? My attempt to keep dependencies low and simple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first pass at adding plugins to spec-md which allow for the generation of output in formats other than HTML.